-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][V1] pluggable scheduler #14466
Conversation
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this add-on, but prefer to be transparent about the compatibility.
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com> Signed-off-by: Richard Liu <ricliu@google.com>
While we wait for the scheduler interface overhaul on #12544, this PR aims to only make the scheduler for the V1 engine pluggable. This allows the
--scheduler-cls
engine arg to continue to function the same way it does in V0.We require this for the vllm-spyre plugin, which overrides the scheduler to add additional constraints based on hardware limitations. If the intent is to go a different direction and not allow the scheduler class to be overridden at runtime for V1, we'd like to know that as well so we can figure out how best to integrate our additional constraints.
FIX vllm-project/vllm-spyre#15