Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][V1] pluggable scheduler #14466

Merged
merged 5 commits into from
Mar 12, 2025

Conversation

joerunde
Copy link
Collaborator

@joerunde joerunde commented Mar 7, 2025

While we wait for the scheduler interface overhaul on #12544, this PR aims to only make the scheduler for the V1 engine pluggable. This allows the --scheduler-cls engine arg to continue to function the same way it does in V0.

We require this for the vllm-spyre plugin, which overrides the scheduler to add additional constraints based on hardware limitations. If the intent is to go a different direction and not allow the scheduler class to be overridden at runtime for V1, we'd like to know that as well so we can figure out how best to integrate our additional constraints.

FIX vllm-project/vllm-spyre#15

joerunde added 2 commits March 7, 2025 16:09

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Copy link

github-actions bot commented Mar 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@joerunde joerunde changed the title V1 pluggable scheduler [core][V1] pluggable scheduler Mar 7, 2025
@mergify mergify bot added the v1 label Mar 7, 2025
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
@joerunde joerunde added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 10, 2025
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this add-on, but prefer to be transparent about the compatibility.

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac enabled auto-merge (squash) March 11, 2025 23:17
@comaniac comaniac merged commit 47532cd into vllm-project:main Mar 12, 2025
34 checks passed
@joerunde joerunde deleted the v1-pluggable-scheduler branch March 12, 2025 14:59
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Richard Liu <ricliu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V1] Pluggable scheduler
3 participants