Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Support Grok1 #13795

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Feb 25, 2025

FIX #3472

Ported from https://github.com/ROCm/vllm/blob/main/vllm/model_executor/models/grok1.py with some missing features added - namely enabling logits_soft_cap, proper scaling, and gelu instead of silu

Evaluation on gsm8k using Grok1 FP8 from https://huggingface.co/amd/grok-1-FP8-KV

lm_eval --model vllm --model_args pretrained=amd/grok-1-FP8-KV,tensor_parallel_size=8 --trust_remote_code --tasks gsm8k --num_fewshot 5 --batch_size auto

vllm (pretrained=amd/grok-1-FP8-KV,tensor_parallel_size=8,trust_remote_code=True), gen_kwargs: (None), limit: None, num_fewshot: 5, batch_size: auto
|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.6073|±  |0.0135|
|     |       |strict-match    |     5|exact_match|↑  |0.5883|±  |0.0136|

Verified that vllm serve amd/grok-1-FP8-KV -pp 8 --trust-remote-code works

Signed-off-by: mgoin <mgoin64@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin added the new model Requests to new models label Feb 25, 2025
@mgoin mgoin marked this pull request as ready for review February 25, 2025 01:42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: mgoin <mgoin64@gmail.com>
@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 25, 2025
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also cc @DarkLight1337

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 25, 2025 03:33
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 25, 2025
@DarkLight1337
Copy link
Member

Please update the model registry tests to include this model.

Signed-off-by: mgoin <mgoin64@gmail.com>
@DarkLight1337 DarkLight1337 merged commit 07c4353 into vllm-project:main Feb 26, 2025
49 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
Signed-off-by: mgoin <mgoin64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation new model Requests to new models ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Model]: Request to support xai-org/grok-1 (314B parameters with MOE architecture)
3 participants