Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] LoRA V1 - Add add/pin/list/remove_lora functions #13705

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

varun-sundar-rabindranath
Copy link
Contributor

@varun-sundar-rabindranath varun-sundar-rabindranath commented Feb 22, 2025

Add pin_lora, list_lora and remove_lora functions to V1 LLMEngine and AsyncLLM classes. Additionally add add_lora function to the LLMEngine class.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 22, 2025
Copy link

mergify bot commented Feb 22, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @varun-sundar-rabindranath.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 22, 2025
@varun-sundar-rabindranath
Copy link
Contributor Author

Thanks @njhill for #13060 - It made the testing much easier. 🙌

Copy link

mergify bot commented Feb 23, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @varun-sundar-rabindranath.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 23, 2025
Signed-off-by: Varun Sundar Rabindranath <varun@neuralmagic.com>
Varun Sundar Rabindranath added 2 commits February 23, 2025 11:08
Signed-off-by: Varun Sundar Rabindranath <varun@neuralmagic.com>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Varun Sundar Rabindranath <varun@neuralmagic.com>
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 24, 2025
@njhill
Copy link
Member

njhill commented Feb 24, 2025

@varun-sundar-rabindranath looks like there's some lora test failures.

@jeejeelee
Copy link
Collaborator

The failure of lora4 is a known issue, and the failure of lora3 appears to be caused by this PR.

fix tests
Signed-off-by: Varun Sundar Rabindranath <varun@neuralmagic.com>
@varun-sundar-rabindranath
Copy link
Contributor Author

Thanks @jeejeelee and @njhill ! I pushed a fix and it should pass now 🤞

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 25, 2025 08:17
@simon-mo simon-mo merged commit 03f48b3 into vllm-project:main Feb 25, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants