-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] LoRA V1 - Add add/pin/list/remove_lora functions #13705
[Core] LoRA V1 - Add add/pin/list/remove_lora functions #13705
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This pull request has merge conflicts that must be resolved before it can be |
0b0ba9e
to
ffe4189
Compare
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Varun Sundar Rabindranath <varun@neuralmagic.com>
ffe4189
to
73ae9bf
Compare
Signed-off-by: Varun Sundar Rabindranath <varun@neuralmagic.com>
Signed-off-by: Varun Sundar Rabindranath <varun@neuralmagic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @varun-sundar-rabindranath, LGTM
@varun-sundar-rabindranath looks like there's some lora test failures. |
The failure of lora4 is a known issue, and the failure of lora3 appears to be caused by this PR. |
Thanks @jeejeelee and @njhill ! I pushed a fix and it should pass now 🤞 |
Add pin_lora, list_lora and remove_lora functions to V1 LLMEngine and AsyncLLM classes. Additionally add add_lora function to the LLMEngine class.