Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Allow sliding window + prefix caching #13069

Merged
merged 1 commit into from
Mar 12, 2025
Merged

[V1] Allow sliding window + prefix caching #13069

merged 1 commit into from
Mar 12, 2025

Conversation

WoosukKwon
Copy link
Collaborator

The KV cache manager in V1 ignores sliding window, so prefix caching is compatible with sliding window attention.

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we have a test for it?

@DarkLight1337
Copy link
Member

tests/prefix_caching/test_disable_sliding_window.py::test_disable_sliding_window fails using V1 on main - perhaps we can update this test in this PR?

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 9, 2025 14:56
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 9, 2025
@aarnphm aarnphm added the v1 label Mar 12, 2025
@simon-mo simon-mo disabled auto-merge March 12, 2025 18:21
@simon-mo simon-mo merged commit 53be4a8 into main Mar 12, 2025
44 of 48 checks passed
@simon-mo simon-mo deleted the v1-sliding branch March 12, 2025 18:21
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Richard Liu <ricliu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force-merge ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants