Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hardware][Intel-Gaudi] Enable FusedSDPA support for Intel Gaudi (HPU) #12359

Merged
merged 1 commit into from
Feb 5, 2025
Merged

[Hardware][Intel-Gaudi] Enable FusedSDPA support for Intel Gaudi (HPU) #12359

merged 1 commit into from
Feb 5, 2025
+11 −1

Conversation

scsudhak-intel
Copy link
Contributor

@scsudhak-intel scsudhak-intel commented Jan 23, 2025 •
edited by github-actions bot
Loading

FusedSDPA is a Gaudi specific implementation of flash attention. https://docs.habana.ai/en/v1.19.1/PyTorch/Model_Optimization_PyTorch/Optimization_in_PyTorch_Models.html

This PR enables support for FusedSDPA in Intel Gaudi accelerators.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@scsudhak-intel scsudhak-intel marked this pull request as ready for review January 28, 2025 09:36
kzawora-intel
kzawora-intel reviewed Jan 28, 2025
View reviewed changes
vllm/attention/backends/hpu_attn.py Outdated
Comment on lines 134 to 136
HPUFusedSDPA = FusedSDPA
self.fused_scaled_dot_product_attention = None if HPUFusedSDPA is None \
else ModuleFusedSDPA(HPUFusedSDPA)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not consider VLLM_PROMPT_USE_FUSEDSDPA defined in hpu_model_runner.py:295 - doesn't this break the default scenario, considering that non-FSDPA case requires different attention bias handling than the default implementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporated the suggested changes as per our offline discussion.

mgoin
mgoin approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 4, 2025
@mgoin mgoin enabled auto-merge (squash) February 4, 2025 16:22
@scsudhak-intel
Enable FusedSDPA support for HPU
Loading
Loading status checks…
a34ab04 
Signed-off-by: Sanju C Sudhakaran <scsudhakaran@habana.ai>
auto-merge was automatically disabled February 5, 2025 04:55

Head branch was pushed to by a user without write access

@simon-mo simon-mo merged commit af8486d into vllm-project:main Feb 5, 2025
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin

@kzawora-intel kzawora-intel

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scsudhak-intel @mgoin @kzawora-intel @simon-mo