Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-node): fix missing buildStart #7652

Merged
merged 4 commits into from
Mar 14, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Mar 11, 2025

Description

It looks like css wasn't broken in vite-node since it always executed /@vite/env and this somehow ended up as web transform, which ensures client environment buildStart to be triggered.

It turned out this can still break when users chose --options.transformMode.ssr=".*" #7666. Until vitejs/vite#19624 is released, we can workaround this by grabbing client.pluginContainer.buildStart directly.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5b5b57b
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67d21d6acc68700008190355
😎 Deploy Preview https://deploy-preview-7652--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@hi-ogawa hi-ogawa changed the title fix(vite-node): fix buildStart fix(vite-node): fix missing buildStart Mar 13, 2025

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@hi-ogawa hi-ogawa marked this pull request as ready for review March 13, 2025 00:16
@sheremet-va sheremet-va merged commit 29f5a84 into vitest-dev:main Mar 14, 2025
13 checks passed
@hi-ogawa hi-ogawa deleted the fix-revert-buildStart branch March 14, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite-node CLI/binary is completely broken
2 participants