Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-worker): ensure removeEventListener is bound to worker #7631

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

joelgallant
Copy link
Contributor

@joelgallant joelgallant commented Mar 7, 2025

Description

In jsdom + vitest web-workers, I get issues when calling removeEventListener from self.

'removeEventListener' called on an object that is not a valid instance of EventTarget

I tracked this down to the inserted context that web-worker inserts. This PR fixes it.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Screenshot From 2025-03-07 11-40-31

^ Test that fails before my patch

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Sorry, something went wrong.

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8033e5a
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67cb3d87efbdd70008c4101d
😎 Deploy Preview https://deploy-preview-7631--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@joelgallant joelgallant force-pushed the remove-event-listener-bind branch from 352991e to ee59971 Compare March 7, 2025 19:08
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch! 💯

@AriPerkkio AriPerkkio changed the title Ensure that removeEventListener is bound to the correct EventTarget fix(web-worker): ensure removeEventListener is bound to EventTarget Mar 11, 2025
@AriPerkkio AriPerkkio changed the title fix(web-worker): ensure removeEventListener is bound to EventTarget fix(web-worker): ensure removeEventListener is bound to worker Mar 11, 2025
@AriPerkkio AriPerkkio merged commit ff42bcb into vitest-dev:main Mar 11, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants