Revert "fix(browser): remove @testing-library/dom from dependencies #7555)" #7628
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itest-dev#7555)" This reverts commit 5387a5b.
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Any ETA on releasing a new version with this fix? |
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Mar 12, 2025
now that api-extractor bundles v5.8.2 also need to pin vitest to 3.0.7 because 3.0.8 broke installation and we need the following fix to be published vitest-dev/vitest#7628 - rush update --full
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Mar 13, 2025
until vitest-dev/vitest#7628 is released.
jeremymeng
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Mar 13, 2025
Pin vitest to 3.0.7 because 3.0.8 broke installation and we need the following fix to be published vitest-dev/vitest#7628 - rush update --full
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5387a5b.
It is actually used by
user-event. Removing it from dependencies breaks certain package managers like Yarn PnP even if preview provider is not used.Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.