fix: cleanup vitest in public resolveConfig
API
#7623
Merged
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we get a huge wall of logs like this https://github.com/vitest-dev/vitest/actions/runs/13711813132/job/38349623334?pr=7621#step:8:458
Some are due to test not doing proper cleanup. Also public
resolveConfig
API had hangingnew Vitest
, so I made it close properly.I fixed all except these two https://github.com/vitest-dev/vitest/actions/runs/13712690144/job/38352041269?pr=7623#step:8:457, which can be reproduce by
Probably this is due to error handler not cleaned up when resolve config is throwing. It should be fixed, but I guess we can deal with this later.
vitest/test/config/test/override.test.ts
Lines 304 to 306 in cad3d75
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.