fix(coverage): browser mode + coverage.all

[AriPerkkio]

Description

• Fixes Import conditions not respected on main thread #7588
• Ref. fix(coverage): use project specific vitenode for uncovered files #6044 (comment)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
• Ideally, include a test that fails without this PR but passes with it.
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

• Run the tests with pnpm test:ci.

Documentation

• If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

[pkg-pr-new]

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7597

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7597

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7597

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7597

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7597

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7597

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7597

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7597

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7597

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7597

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7597

vite-node

npm i https://pkg.pr.new/vite-node@7597

vitest

npm i https://pkg.pr.new/vitest@7597

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7597

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7597

commit: e653bec

[netlify]

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	e653bec
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/67d04ffe5dc8590008bda006
😎 Deploy Preview	https://deploy-preview-7597--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[AriPerkkio]

Alright the Windows issues are finally resolved. @mrginglymus could you do one final check with https://pkg.pr.new/vitest@12d473c and equivalent preview packages with your real-world project?

[AriPerkkio]

On Windows the root is here D:/a/vitest/vitest/test/coverage-test while filename is /D:/a/vitest/vitest/test/coverage-test/fixtures/src/untested-file.ts.

[AriPerkkio]

/ecosystem-ci run

[vitest-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
aria-live-capture	✅ success
nuxt	❌ failure
nuxt-test-utils	✅ success
elk	✅ success
effect	❌ failure
lerna-lite	✅ success
zustand	✅ success
vue	✅ success
vite	✅ success
vitest-vscode	✅ success
vitest-sonar-reporter	✅ success
vitest-browser-examples	✅ success
vitest-coverage-large	✅ success
vitest-reporters-large	✅ success
vitest-benchmark-large	✅ success

[mrginglymus]

Alright the Windows issues are finally resolved. @mrginglymus could you do one final check with https://pkg.pr.new/vitest@12d473c and equivalent preview packages with your real-world project?

@AriPerkkio yes this is working correctly on my real-world project. Thanks so much for the effort in fixing this!

[hi-ogawa]

Looks good to me 👍
How did you eventually fix optimize deps error? Is it by switching vitenode.transformRequest with browser.transformRequest #7597 (comment)?

[AriPerkkio]

How did you eventually fix optimize deps error? Is it by switching vitenode.transformRequest with browser.transformRequest #7597 (comment)?

Switching to vitenode.transformRequest is a way to avoid it, yes.

But when using browser, this change was enough to fix it. And when doing parallel requests, it was important not to reset noDiscovery back.

+ browser.config.optimizeDeps.noDiscovery = true
const result = await browser?.transformRequest(filename).catch(() => null)

Setting the server.preTransformRequests had no effect at all - Vite was still following dependencies of requested modules. 🤷

[hi-ogawa]

But, if this relies on vite node's server and browser mode's server being different, would it potentially block the plan of merging the server? #6912

[sheremet-va]

But, if this relies on vite node's server and browser mode's server being different, would it potentially block the plan of merging the server? #6912

How does it matter though? The code output is the same, isn't it what matters here?

[hi-ogawa]

I thought the difference is vite-node's server explicitly configures optimizeDeps.noDiscovery: true + preTransformRequests: false, but browser's server has opposite (i.e. normal Vite app default).

[sheremet-va]

I thought the difference is vite-node's server explicitly configures optimizeDeps.noDiscovery: true + preTransformRequests: false, but browser's server has opposite (i.e. normal Vite app default).

Yes, but does it matter for coverage what these options are?

[hi-ogawa]

I thought the difference is vite-node's server explicitly configures optimizeDeps.noDiscovery: true + preTransformRequests: false, but browser's server has opposite (i.e. normal Vite app default).

Yes, but does it matter for coverage what these options are?

I would imagine transformRequest output is same, but as Ari said #7597 (comment), without noDiscovery, Vite server would eagerly crawl and potentially trigger optimize deps, so such side effect is not ideal for our usage of transformRequest for coverage.all.
(actually I don't know what's bad about this, but at least, optimize deps might show odd error/warning from esbuild?)

I think it's good to land with vitenode.transformRequest, but we might need to revisit this when #6912. I don't know whether we need something new from Vite or we can use extra inline environment for this transform, or something else.