-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(coverage): support overriding exclude
#5997
Merged
sheremet-va
merged 3 commits into
vitest-dev:main
from
AriPerkkio:fix/coverage-exclude-override
Jul 1, 2024
Merged
fix(coverage): support overriding exclude
#5997
sheremet-va
merged 3 commits into
vitest-dev:main
from
AriPerkkio:fix/coverage-exclude-override
Jul 1, 2024
+102
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
1b3c49a
to
9ee4549
Compare
sheremet-va
reviewed
Jun 29, 2024
9ee4549
to
8014e0e
Compare
8014e0e
to
c7f33bf
Compare
sheremet-va
approved these changes
Jul 1, 2024
6 tasks
1 task
1 task
This was referenced Sep 10, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
coverage.exclude
should be fully configurable #5965Previously Vitest did not allow user to override default
coverage.exclude
. In cases like #5964 this caused issues where users were completely unable to get coverage of files that were located indist/**
, as defaults were hard-coded and didn't allow overrides. Now Vitest allows users to completely overridecoverage.exclude
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.