Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): don't call process.exit manually #5926

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Jun 19, 2024

Description

fixes #5913

Vitest API will now throw an error (TestsNotFoundError) when calling start manually. Vitest will also throw GitNotFoundError error if changed flag was used but there is no git repository available.

Both of these errors can be imported from vitest/node.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@sheremet-va
Copy link
Member Author

Should also remove here:

process.exit = (() => { }) as never

Comment on lines 495 to 496
process.exitCode = exitCode
throw new NoTestsFoundError()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #5913

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@sheremet-va sheremet-va merged commit e9b638d into vitest-dev:main Jul 1, 2024
16 checks passed
@sheremet-va sheremet-va deleted the fix/exit-process-cleanup branch July 1, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Node process exits via Node APIs when no test files found
2 participants