Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): save splitpanes size to local storage #5166

Merged
merged 1 commit into from Feb 12, 2024

Conversation

posva
Copy link
Contributor

@posva posva commented Feb 9, 2024

Description

Saves the size of the splitpanes to the local storage for convenience when reloading between testing sessions

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 93d1a79
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65c63f858b9f1800084d9eee

Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you 🙏🏻 It's been some time since we got any PRs to improve the UI 😄

@sheremet-va sheremet-va added this to the 1.3.0 milestone Feb 9, 2024
@posva
Copy link
Contributor Author

posva commented Feb 9, 2024

This was such an easy contribution! I hope it helps others, too 😄
The UI is already pretty nice, to be honest; keep up the good job! 👏

@sheremet-va sheremet-va merged commit c28b4c2 into vitest-dev:main Feb 12, 2024
16 of 19 checks passed
@posva posva deleted the feat/ui-save-panes-size branch February 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants