Latest vitest and happy-dom with useFakeTimers - Test runner is stuck forever

[aversini]

Describe the bug

Test runner is stuck with the most recent versions of both Vitest (1.2.x) and HappyDom (13.x). If one of the version is reduced (Vitest to 1.1.3 or HappyDom to 12.x), then the test is running fine.

Reproduction

• Install vitest 1.2.x
• Install happy-dom 13.x
• Use "vi.useFakeTimers()"
• Run the test (vitest run)
• The test is stuck and never return to the command line

Repo to reproduce the issue: https://stackblitz.com/edit/vitest-dev-vitest-bhbpda?file=src%2Findex.ts

This issue may have been introduced by this recent PR: #4931
I tried to play around with this PR, and by just changing this line,
from

await win.happyDOM.abort()

to

win.happyDOM.abort()

it does lift the block... however win.happyDOM.abort returns a Promise, so it does not seem right.

cc @capricorn86

System Info

System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M2
    Memory: 102.05 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
    Yarn: 4.0.2 - ~/.nvm/versions/node/v20.11.0/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
  Browsers:
    Chrome: 120.0.6099.216
    Edge: 120.0.2210.133
    Safari: 17.2.1
    Safari Technology Preview: 17.4
  npmPackages:
    @vitest/coverage-v8: 1.2.0 => 1.2.0
    @vitest/ui: 1.2.0 => 1.2.0
    vitest: 1.2.0 => 1.2.0
    happy-dom: 13.0.6

Used Package Manager

npm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[capricorn86]

This seem to be related to vi.useFakeTimers(). Removing that statement makes the tests run through.

await win.happyDOM.abort() is trying to abort ongoing timers, but perhaps it collides with internal logic inside Vitest.

[capricorn86]

I have found the issue and will soon have a fix in Happy DOM.

Task capricorn86/happy-dom#1210 created.

[capricorn86]

@aversini this has been fixed now in the latest version of Happy DOM:
https://github.com/capricorn86/happy-dom/releases/tag/v13.0.7

[aversini]

@capricorn86 the issue is indeed gone with your recent fix, thanks for the speedy attention and the amazing work you do on Happy DOM ✨

[capricorn86]

Thank you @aversini!