fix(vitest): add inlined deps to ssr.noExternal so they are added to the module graph

[sheremet-va]

Description

Fixes #4785

This fixes the first case when changing code in dependencies with node environment did not trigger an HMR update.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
• Ideally, include a test that fails without this PR but passes with it.
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

• Run the tests with pnpm test:ci.

Documentation

• If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

[netlify]

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name	Link
🔨 Latest commit	0814f22
🔍 Latest deploy log	https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65a1242503fe920008bef948

[Jinjiang]

@sheremet-va after testing in the same repo https://github.com/Jinjiang/reproductions/tree/vitest-watch-node_modules-20231220 with v1.2.0:

in 'jsdom' environment:

modify code in node_modules/foo-cjs/index.js or node_modules/foo-esm/index.js or node_modules/foo-cjs/foo.js or node_modules/foo-esm/foo.js

• when you first time modify it, the test is not re-run
• when you further modify it, the test is re-run, but the result is the same

in default ('node') environment:

modify code in node_modules/foo-cjs/index.js or node_modules/foo-esm/index.js or node_modules/foo-cjs/foo.js or node_modules/foo-esm/foo.js

• when you first time modify it, the test is not re-run
• when you further modify it, the test is re-run, and the result is the updated one

It seems still have issues.

Would you mind check again?

Thanks.

[sheremet-va]

I mentioned it in another PR, this is upstream issue with a watcher, it doesn’t emit change event on the first edit - I don’t think there is anything we can do.

The error with jsdom with the same result I will check, it should update the result.

[Jinjiang]

I see. For the upstream watcher, is there a GitHub issue that we can keep tracking on? Or do you think we can create one for them? (Sorry I'm not familiar with this behind.)

[sheremet-va]

Vite uses chokidar for its file watcher. I thought the reason why it doesn't work might be because followSymlinks is not enabled by default, but toggling it on and off didn't change anything for me unfortunately.

[sheremet-va]

Ah, it looks like watcher uses another event for the first change in node_modules. I will look more into it.

[Jinjiang]

Confirmed it works as expected with v1.2.1. Thanks so much!