feat: support case-insensitive path matching in cli (fix #3567) #4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
reviewed
Jan 9, 2024
packages/vitest/src/node/cli.ts
Outdated
| @@ -192,7 +192,7 @@ async function start(mode: VitestRunMode, cliFilters: string[], options: CliOpti | |||
| catch {} | |||
|
|
|||
| try { | |||
| const ctx = await startVitest(mode, cliFilters.map(normalize), normalizeCliOptions(options)) | |||
| const ctx = await startVitest(mode, cliFilters.map(cliFilter => normalize(cliFilter.toLocaleLowerCase())), normalizeCliOptions(options)) | |||
There was a problem hiding this comment.
What happens if the actual file has an uppercase letter? Would this filter work?
vitest SOME-name.js
./some-name.js
./SOME-name.js
There was a problem hiding this comment.
What happens if the actual file has an uppercase letter? Would this filter work?
vitest SOME-name.js ./some-name.js ./SOME-name.js
There were problems with uppercase letter files, I made changes.
tigranmk
force-pushed
the
feat/case-insensitive
branch
3 times, most recently
from
e94185d
to
04a94f8
Compare
tigranmk
force-pushed
the
feat/case-insensitive
branch
from
04a94f8
to
6732a8d
Compare
sheremet-va
approved these changes
Jan 12, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #3567
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.