Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): reset "current test" state on dynamic skip #4814

Merged

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Dec 28, 2023

Description

Closes #4812

The tests I added are not a repro of the referenced issue, but I think this test demonstrates the fix more concisely.

I also locally verified the issue's repro is fixed. If it's desired to add such tests, then I can do that, but I felt it's a little overkill since it would probably requires a dedicated test directory and singleThread option to reproduce.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Sorry, something went wrong.

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 10cb17a
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/658d0cbced5d2b0008035091

@hi-ogawa hi-ogawa marked this pull request as ready for review December 28, 2023 06:02
@sheremet-va sheremet-va merged commit 19faf00 into vitest-dev:main Dec 28, 2023
@hi-ogawa hi-ogawa deleted the fix-reset-current-test-on-dynamic-skip branch December 28, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Nested tests are not allowed" error even if tests are not nested
2 participants