Skip to content

Commit fe2a187

Browse files
authoredDec 1, 2024··
fix(types): make parameters non-nullable for Playwright options (#6989)
1 parent 721a5b8 commit fe2a187

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed
 

‎packages/browser/providers/playwright.d.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ declare module 'vitest/node' {
2727
}
2828
}
2929

30-
type PWHoverOptions = Parameters<Page['hover']>[1]
31-
type PWClickOptions = Parameters<Page['click']>[1]
32-
type PWDoubleClickOptions = Parameters<Page['dblclick']>[1]
33-
type PWFillOptions = Parameters<Page['fill']>[2]
34-
type PWScreenshotOptions = Parameters<Page['screenshot']>[0]
35-
type PWSelectOptions = Parameters<Page['selectOption']>[2]
36-
type PWDragAndDropOptions = Parameters<Page['dragAndDrop']>[2]
30+
type PWHoverOptions = NonNullable<Parameters<Page['hover']>[1]>
31+
type PWClickOptions = NonNullable<Parameters<Page['click']>[1]>
32+
type PWDoubleClickOptions = NonNullable<Parameters<Page['dblclick']>[1]>
33+
type PWFillOptions = NonNullable<Parameters<Page['fill']>[2]>
34+
type PWScreenshotOptions = NonNullable<Parameters<Page['screenshot']>[0]>
35+
type PWSelectOptions = NonNullable<Parameters<Page['selectOption']>[2]>
36+
type PWDragAndDropOptions = NonNullable<Parameters<Page['dragAndDrop']>[2]>
3737

3838
declare module '@vitest/browser/context' {
3939
export interface UserEventHoverOptions extends PWHoverOptions {}

‎packages/browser/src/node/commands/hover.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export const hover: UserEventCommand<UserEvent['hover']> = async (
1616
}
1717
else if (context.provider instanceof WebdriverBrowserProvider) {
1818
const browser = context.browser
19-
await browser.$(selector).moveTo(options)
19+
await browser.$(selector).moveTo(options as any)
2020
}
2121
else {
2222
throw new TypeError(`Provider "${context.provider.name}" does not support hover`)

0 commit comments

Comments
 (0)
Please sign in to comment.