Skip to content

Commit db14ab7

Browse files
authoredMar 7, 2025··
fix: cleanup vitest in public resolveConfig API (#7623)
1 parent 4f7db68 commit db14ab7

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed
 

‎packages/vitest/src/node/plugins/publicConfig.ts

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ export async function resolveConfig(
4949
updatedOptions,
5050
config,
5151
)
52+
await vitest.close()
5253
return {
5354
viteConfig: config,
5455
vitestConfig,

‎test/config/test/browser-configs.test.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
import type { ViteUserConfig } from 'vitest/config'
22
import type { UserConfig, VitestOptions } from 'vitest/node'
3-
import { expect, test } from 'vitest'
3+
import { expect, onTestFinished, test } from 'vitest'
44
import { createVitest } from 'vitest/node'
55

66
async function vitest(cliOptions: UserConfig, configValue: UserConfig = {}, viteConfig: ViteUserConfig = {}, vitestOptions: VitestOptions = {}) {
7-
return await createVitest('test', { ...cliOptions, watch: false }, { ...viteConfig, test: configValue as any }, vitestOptions)
7+
const vitest = await createVitest('test', { ...cliOptions, watch: false }, { ...viteConfig, test: configValue as any }, vitestOptions)
8+
onTestFinished(() => vitest.close())
9+
return vitest
810
}
911

1012
test('assignes names as browsers', async () => {

‎test/config/test/override.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
import type { UserConfig as ViteUserConfig } from 'vite'
22
import type { UserConfig } from 'vitest/node'
3-
import { describe, expect, it } from 'vitest'
3+
import { describe, expect, it, onTestFinished } from 'vitest'
44
import { extraInlineDeps } from 'vitest/config'
55
import { createVitest, parseCLI } from 'vitest/node'
66

77
type VitestOptions = Parameters<typeof createVitest>[3]
88

99
async function vitest(cliOptions: UserConfig, configValue: UserConfig = {}, viteConfig: ViteUserConfig = {}, vitestOptions: VitestOptions = {}) {
1010
const vitest = await createVitest('test', { ...cliOptions, watch: false }, { ...viteConfig, test: configValue as any }, vitestOptions)
11+
onTestFinished(() => vitest.close())
1112
return vitest
1213
}
1314

0 commit comments

Comments
 (0)
Please sign in to comment.