Skip to content

Commit 7f45bf2

Browse files
committedAug 1, 2023
perf: deprecate deps.registerNodeLoader
1 parent b8dc99b commit 7f45bf2

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed
 

‎packages/vitest/src/node/config.ts

+9-3
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,15 @@ export function resolveConfig(
184184
?? resolve(resolved.root, resolved.runner)
185185
}
186186

187-
// disable loader for Yarn PnP until Node implements chain loader
188-
// https://github.com/nodejs/node/pull/43772
189-
resolved.deps.registerNodeLoader ??= false
187+
if (resolved.deps.registerNodeLoader) {
188+
const transformMode = resolved.environment === 'happy-dom' || resolved.environment === 'jsdom' ? 'web' : 'ssr'
189+
console.warn(
190+
c.yellow(
191+
`${c.inverse(c.yellow(' Vitest '))} "deps.registerNodeLoader" is deprecated.`
192+
+ `If you rely on aliases inside external packages, use "deps.optimizer.${transformMode}.include" instead.`,
193+
),
194+
)
195+
}
190196

191197
resolved.testNamePattern = resolved.testNamePattern
192198
? resolved.testNamePattern instanceof RegExp

‎packages/vitest/src/types/config.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -143,21 +143,20 @@ interface DepsOptions {
143143
* @default false
144144
*
145145
* @deprecated Use `server.deps.fallbackCJS` instead.
146-
*
147146
*/
148147
fallbackCJS?: boolean
149148

150149
/**
151150
* Use experimental Node loader to resolve imports inside node_modules using Vite resolve algorithm.
152151
* @default false
152+
* @deprecated If you rely on aliases inside external packages, use `deps.optimizer.{web,ssr}.include` instead.
153153
*/
154154
registerNodeLoader?: boolean
155155

156156
/**
157157
* A list of directories relative to the config file that should be treated as module directories.
158158
*
159159
* @default ['node_modules']
160-
*
161160
*/
162161
moduleDirectories?: string[]
163162
}

0 commit comments

Comments
 (0)
Please sign in to comment.