Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: gRPC custom name resolvers don't work with underscores #15721

Open
notfelineit opened this issue Apr 15, 2024 · 0 comments · May be fixed by #15722
Open

Bug Report: gRPC custom name resolvers don't work with underscores #15721

notfelineit opened this issue Apr 15, 2024 · 0 comments · May be fixed by #15722
Assignees
@notfelineit
Labels
Component: VTAdmin VTadmin interface Type: Bug

Comments

@notfelineit
Copy link
Contributor

Overview of the Issue

vtadmin-api fails to connect to vtgate & vtctld if there are underscores (_) in the cluster ID name. I think this is because gRPC doesn't handle custom name resolvers with _.

Reproduction Steps

Modify clustername in vtadmin-up.sh to a name with underscores:

cluster_name="local_test"

vtadmin-api will fail to connect to vtgate and vtctld.

Binary Version

vtadmin version Version: 17.0.0-SNAPSHOT (Git revision e5de85346b7ddcc6d0b69bcbab2dda4e5f661526 branch 'debug-image') built on Fri Apr 12 14:48:12 PDT 2024 by francesthai@localhost.local using go1.21.9 darwin/amd64

(also present on v18-v20)

Operating System and Environment details

- Operating system: macOS 14.4.1 (23E224)
- Kernel version: Darwin 23.4.0
- Architecture: x86_64

Log Fragments

No response
@notfelineit notfelineit added Type: Bug Needs Triage This issue needs to be correctly labelled and triaged labels Apr 15, 2024
@notfelineit notfelineit self-assigned this Apr 15, 2024
@notfelineit notfelineit added Component: VTAdmin VTadmin interface and removed Needs Triage This issue needs to be correctly labelled and triaged labels Apr 15, 2024
@notfelineit notfelineit linked a pull request Apr 15, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notfelineit notfelineit

Labels
Component: VTAdmin VTadmin interface Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[VTAdmin API] Replace underscores with dashes in cluster ID planetscale/vitess
1 participant
@notfelineit