Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: deprecation of gh-ost and pt-osc Online DDL strategies #15692

Open
shlomi-noach opened this issue Apr 10, 2024 · 0 comments
Open

Tracking: deprecation of gh-ost and pt-osc Online DDL strategies #15692

shlomi-noach opened this issue Apr 10, 2024 · 0 comments
Assignees
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Internal Cleanup

Comments

@shlomi-noach
Copy link
Contributor

Vitess (v19) supports these Online DDL strategies:

Both gh-ost and pt-online-schema-change are external to Vitess, and the Vitess maintainers do not actively participate in supporting these tools. We therefore wish to remove support for the respective strategies. See below.

pt-osc removal (version TBD)

From day 1, pt-osc strategy was marked as experimental. As such, it was never truly supported. The Vitess authors have no information about how community might be using pt-osc as an Online DDL strategy.

  • We wish to remove this strategy altogether, along with the code that implements it.
  • Specifying --ddl-strategy="pt-osc" will throw an error.

gh-ost

gh-ost is known to be in use in the community, at least on older versions of Vitess. The Vitess maintainers have themselves used gh-ost in production at PlanetScale for a substantial period of time with good results.

We wish to deprecate gh-ost in multiple stages.

Stage 1, unsupport, slated to v20

  • Mark gh-ost strategy unsupported and experimental.
  • Today, vttablet binary embeds a gh-ost binary. We will remove it. Users will need to supply their own gh-ost binary.
  • Remove gh-ost related endtoend tests from CI.
  • --ddl-strategy="gh-ost" will still work, nothing changes.

Stage 2, removal (version TBD)

  • Remove gh-ost supporting code.
  • --ddl-strategy="gh-ost" will throw an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Internal Cleanup
Projects
None yet
Development

No branches or pull requests

1 participant