Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen4 planner: allow last_insert_id with arguments (16.0) #13033

Merged
merged 1 commit into from May 9, 2023

Conversation

systay
Copy link
Collaborator

@systay systay commented May 8, 2023

Description

We (incorrectly) decided to disallow last_insert_id some time ago, although it was actually working and being used.

Related Issue(s)

Fixed #13020
Backport of #13026

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Signed-off-by: Andres Taylor <andres@planetscale.com>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels May 8, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented May 8, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@systay systay removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels May 8, 2023
@github-actions github-actions bot added this to the v16.0.2 milestone May 8, 2023
@GuptaManan100 GuptaManan100 added the Release Blocker: release-19.0 This issue will be marked as blocking the release by the vitess-releaser label May 9, 2023
@GuptaManan100 GuptaManan100 merged commit 24ca345 into vitessio:release-16.0 May 9, 2023
112 of 116 checks passed
@GuptaManan100 GuptaManan100 deleted the last-inser-16 branch May 9, 2023 06:03
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport This is a backport Component: Query Serving Release Blocker: release-19.0 This issue will be marked as blocking the release by the vitess-releaser Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants