Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen4 planner: allow last_insert_id with arguments #13026

Merged
merged 1 commit into from May 8, 2023

Conversation

systay
Copy link
Collaborator

@systay systay commented May 5, 2023

Description

We (incorrectly) decided to disallow last_insert_id some time ago, although it was actually working and being used.

Related Issue(s)

Fixed #13020

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels May 5, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented May 5, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.0 milestone May 5, 2023
@arthurschreiber
Copy link
Contributor

This supersedes #12997.

@systay systay added Type: Bug Component: Query Serving Type: Regression Backport to: release-14.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels May 8, 2023
@systay systay marked this pull request as ready for review May 8, 2023 06:11
Signed-off-by: Andres Taylor <andres@planetscale.com>
Comment on lines +570 to +577
lowered := node.Name.Lowered()
if lowered == "last_insert_id" && len(node.Exprs) > 0 {
// if we are dealing with is LAST_INSERT_ID() with an argument, we don't need to rewrite it.
// with an argument, this is an identity function that will update the session state and
// sets the correct fields in the OK TCP packet that we send back
return
}
bindVar, found := funcRewrites[lowered]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this check can be moved down. if the function is present in funcRewrites

@systay systay merged commit fd81a3a into vitessio:main May 8, 2023
112 checks passed
@systay systay deleted the last_insert_id branch May 8, 2023 08:37
@vitess-bot
Copy link
Contributor

vitess-bot bot commented May 8, 2023

I was unable to backport this Pull Request to the following branches: release-14.0, release-15.0, release-16.0.

systay added a commit to planetscale/vitess that referenced this pull request May 8, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay added a commit to planetscale/vitess that referenced this pull request May 8, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay added a commit to planetscale/vitess that referenced this pull request May 8, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
GuptaManan100 pushed a commit that referenced this pull request May 9, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal pushed a commit that referenced this pull request May 9, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal pushed a commit that referenced this pull request May 9, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: last_insert_id with argument broken starting Vitess 16.0.0
3 participants