fix(worker): fix importScripts injection breaking iife code
#17827
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This reverts commit 10fb68d.
hi-ogawa
changed the title
injectScripts injectionimportScripts injection breaking iife code
hi-ogawa
commented
Aug 6, 2024
.prettierignore
Outdated
| @@ -11,3 +11,4 @@ playground/html/invalid.html | |||
| playground/html/valid.html | |||
| playground/external/public/slash@3.0.0.js | |||
| playground/ssr-html/public/slash@3.0.0.js | |||
| playground/worker/classic-iife.js | |||
There was a problem hiding this comment.
prettier-ignore comment doesn't seem to avoid prepending ; to (() => {})(), so I needed to prettierignore an entire file.
Technically we could test the same thing by just adding (() => {})() to existing playground/worker/classic-worker.js, but that would require prettierignore-ing that file, so I added a new file playground/worker/classic-iife.js just for this.
EDIT: On second thought, doing that seems unnecessary involved, so I went back to prettierignore-ing existing classic-worker.js.
This reverts commit 70c746c.
bluwy
approved these changes
Aug 6, 2024
antfu
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TypeError: importScripts(...) is not a functionwhen running iife-style classic worker during dev #17826