Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use @polka/compression #16146

Merged
merged 5 commits into from Mar 12, 2024
Merged

chore: use @polka/compression #16146

merged 5 commits into from Mar 12, 2024

Conversation

chaejunlee
Copy link
Contributor

Description

I tried to replace middleware/compression to @polka/compression.

Because of lint, I tweaked the eslintrc.cjs as well.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@chaejunlee chaejunlee changed the title refactor: use @polka/compression chore: use @polka/compression Mar 12, 2024
sapphi-red
sapphi-red reviewed Mar 12, 2024
View reviewed changes
.eslintrc.cjs Outdated Show resolved Hide resolved
@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Mar 12, 2024
bluwy
bluwy reviewed Mar 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
patak-dev
patak-dev approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Added it to the 5.2 milestone

@patak-dev patak-dev added this to the 5.2 milestone Mar 12, 2024
@bluwy bluwy merged commit 592c95a into vitejs:main Mar 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

Unfork @polka/compression
4 participants
@chaejunlee @patak-dev @bluwy @sapphi-red