Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssr): import.meta.filename/dirname support #15887

Merged
merged 3 commits into from Mar 12, 2024

Conversation

sapphi-red
Copy link
Member

Description

import.meta.dirname and import.meta.filename are supported in Node 21.2+. We already support this in the Vite Runtime API.

filename: isWindows ? toWindowsPath(filename) : filename,
dirname: isWindows ? toWindowsPath(dirname) : dirname,

It's still a release candidate. If there's a change in Node, I think we can change it in a minor.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p2-nice-to-have Not breaking anything but nice to have (priority) feat: ssr labels Feb 12, 2024
Copy link

stackblitz bot commented Feb 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev previously approved these changes Feb 13, 2024
@patak-dev patak-dev added this to the 5.2 milestone Feb 13, 2024
bluwy
bluwy previously approved these changes Feb 13, 2024
@bluwy bluwy dismissed stale reviews from patak-dev and themself via 2708fac March 12, 2024 14:02
@bluwy bluwy merged commit 74dc73a into vitejs:main Mar 12, 2024
10 checks passed
@sapphi-red sapphi-red deleted the feat/ssr-import-meta-filename branch March 14, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants