Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add entry name to manifest #15849

Merged
merged 2 commits into from Mar 12, 2024

Conversation

brillout
Copy link
Contributor

@brillout brillout commented Feb 8, 2024

Description

Adds chunk.name (the Rollup entry name) to the manifest.

Additional context

This makes finding entries in the manifest much easier. Until now I was using brittle heuristics to find entries in the manifest. I've now stubmled a situation where this PR is needed (when the entry file resolves into a sibling package in a monorepo).

Meta frameworks know the entry names, so adding chunk.name will make it trivial to find entries in the manifest.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Feb 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added p2-nice-to-have Not breaking anything but nice to have (priority) feat: build labels Feb 12, 2024
@patak-dev patak-dev added this to the 5.2 milestone Feb 12, 2024
@patak-dev
Copy link
Member

We discussed this feature in the last Vite team meeting, and we decided to move forward with it in Vite 5.2

@bluwy bluwy changed the title fix: add entry name to manifest feat: add entry name to manifest Mar 12, 2024
@bluwy bluwy merged commit 6d6ae10 into vitejs:main Mar 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: build p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants