Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): call dispose before prune #15782

Merged
merged 3 commits into from
Mar 12, 2024
Merged

fix(hmr): call dispose before prune #15782

merged 3 commits into from
Mar 12, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Feb 2, 2024

Description

Before calling import.meta.hot.prune(), import.meta.hot.dispose() wasn't called, making potential cleanup code not called.

Additional context

Might need to run with ecosystem-ci just in case.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority) labels Feb 2, 2024
Copy link

stackblitz bot commented Feb 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci

This comment was marked as outdated.

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 88216de: Open

suite result latest scheduled
analogjs success success
astro success success
histoire failure failure
ladle success success
laravel failure failure
marko success success
nuxt success success
nx failure failure
previewjs success success
qwik failure failure
rakkas success success
sveltekit success success
unocss success success
vike failure failure
vite-plugin-pwa success success
vite-plugin-react success success
vite-plugin-react-pages success success
vite-plugin-react-swc success success
vite-plugin-svelte success success
vite-plugin-vue success success
vite-setup-catalogue success success
vitepress success success
vitest success success

patak-dev
patak-dev previously approved these changes Feb 12, 2024
@patak-dev patak-dev added this to the 5.2 milestone Feb 12, 2024
@bluwy bluwy merged commit 57628dc into main Mar 12, 2024
10 checks passed
@bluwy bluwy deleted the call-dispose-before-prune branch March 12, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants