Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): handle offset magic-string slice error #15435

Merged
merged 1 commit into from Jan 1, 2024
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 27, 2023

Description

fix #15327

magic-string .slice() may throw an error if the sliced string has removed content. I added a try-catch to fix it.

I was thinking if we could check against the plain string instead, but seems risky if there's added content later in magic-string.

I also refactored the code a bit.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Dec 27, 2023
Copy link

stackblitz bot commented Dec 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy merged commit 5ea9edb into main Jan 1, 2024
10 checks passed
@bluwy bluwy deleted the magic-slice-error branch January 1, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error parsing html while build (Cannot use replaced character as slice start anchor)
2 participants