Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump rollup to 4.13.0 #15295

Merged
merged 2 commits into from Mar 12, 2024
Merged

chore(deps): bump rollup to 4.13.0 #15295

merged 2 commits into from Mar 12, 2024

Conversation

moui0
Copy link
Contributor

@moui0 moui0 commented Dec 9, 2023

Description

rollup 4.7.0 added riscv64 support: rollup/rollup#5288

Updating rollup makes it possible to build vite on riscv64 linux.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Dec 9, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@moui0
Copy link
Contributor Author

moui0 commented Dec 25, 2023

I noticed that my PR has been pending for a while. I understand you might be busy, but I was wondering if you could spare some time to review my code. If there are any feedback or issues, I am more than happy to address them promptly.

Thank you!

@bluwy
Copy link
Member

bluwy commented Dec 26, 2023

Vite doesn't exactly need to bump Rollup though, you can update Rollup in your project yourself with npm update rollup, which works recursively and updates what Vite uses too.

Though I don't think there's much harm with this PR too, it could be something we update in the next minor.

@patak-dev patak-dev added this to the 5.2 milestone Feb 12, 2024
@bluwy
Copy link
Member

bluwy commented Mar 12, 2024

Rollup is now on 4.13.0. Are you able to rebase this to upgrade to 4.13.0 instead?

@bluwy
Copy link
Member

bluwy commented Mar 12, 2024

Thanks for the quick update! Seems like the windows CI is failing (twice), I can help check it

@bluwy bluwy changed the title chore(deps): bump rollup to 4.7.0 chore(deps): bump rollup to 4.13.0 Mar 12, 2024
@bluwy bluwy merged commit 2f95c2b into vitejs:main Mar 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants