Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add '*.mov' to client.d.ts #15189

Merged
merged 2 commits into from Dec 4, 2023
Merged

feat: add '*.mov' to client.d.ts #15189

merged 2 commits into from Dec 4, 2023

Conversation

jorge-ui
Copy link
Contributor

@jorge-ui jorge-ui commented Nov 29, 2023 •
edited by bluwy

fix #15183

@stackblitz StackBlitz
Copy link

stackblitz bot commented Nov 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev changed the title Update client.d.ts - add '*.mov' feat: add '*.mov' to client.d.ts Nov 29, 2023
patak-dev
patak-dev previously approved these changes Nov 29, 2023
View reviewed changes
@bluwy
Copy link
Member

bluwy commented Nov 30, 2023

I think we also need to add it here:

vite/packages/vite/src/node/constants.ts

Lines 112 to 120 in 73ef074

// media
'mp4',
'webm',
'ogg',
'mp3',
'wav',
'flac',
'aac',
'opus',

@patak-dev patak-dev dismissed their stale review November 30, 2023 07:42

Thanks Bjorn! 🙏

@jorge-ui
Copy link
Contributor Author

jorge-ui commented Dec 4, 2023

Thanks @bluwy. Sorry for the delay.
I was able to apply the change and update the pr.
@patak-dev I think we're ready now :)

P.S. This is my first contribution to open source 🙌🏼
Thank you Vite.js team for the amazing work 🔥

bluwy
bluwy approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

patak-dev
patak-dev approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jorge-ui!

@patak-dev patak-dev merged commit d93a211 into vitejs:main Dec 4, 2023
6 of 10 checks passed
@jorge-ui jorge-ui deleted the patch-1 branch December 5, 2023 15:28
@XiSenao XiSenao mentioned this pull request Dec 7, 2023
Closed
7 tasks
@m1san m1san mentioned this pull request Dec 31, 2023
Merged
9 tasks
@bluwy bluwy mentioned this pull request Jan 8, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing media module '*.mov'
3 participants
@jorge-ui @bluwy @patak-dev