Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make htmlFallback more permissive #15059

Merged

Conversation

sapphi-red
Copy link
Member

Description

I only tested the fix in #15025 by fetch('/'). But fetch('/') was sending Accept: */*. 🤦

Also it turns out that wait-on sends Accept: application/json, text/plain, */*. We need to remove the json part.

fixes #15022

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Nov 21, 2023
@sapphi-red
Copy link
Member Author

/ecosystem-ci run

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bluwy was also fine removing this check, so let's go with it. Thanks for re-checking the repro and the quick fix Sapphi!

@patak-dev patak-dev enabled auto-merge (squash) November 21, 2023 13:19
@patak-dev patak-dev merged commit 6fcceeb into vitejs:main Nov 21, 2023
10 checks passed
@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 2847753: Open

suite result latest scheduled
analogjs success success
astro success success
histoire failure failure
ladle success success
laravel failure failure
marko success success
nuxt success success
nx failure failure
previewjs success success
qwik failure failure
rakkas success success
sveltekit failure failure
unocss success success
vike success success
vite-plugin-pwa success success
vite-plugin-react success success
vite-plugin-react-pages success success
vite-plugin-react-swc success success
vite-plugin-svelte success success
vite-plugin-vue success success
vite-setup-catalogue success success
vitepress success success
vitest success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite 5 preview return 404 on / if Accept Header is missing
2 participants