Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backport mdx as known js source (#14560) #14670

Merged
merged 1 commit into from Oct 18, 2023
Merged

Conversation

patak-dev
Copy link
Member

Description

Backport #14560


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Co-authored-by: Mark Dalgleish <mark.john.dalgleish@gmail.com>
@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 17, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be fine as importing MDX file returned an URL to the raw MDX file , which doesn't have usecases I guess. For normal use cases, I believe plugin-react-pages's test would cover it.

@patak-dev patak-dev merged commit 45595ef into v4 Oct 18, 2023
15 checks passed
@patak-dev patak-dev deleted the feat/backport-14560 branch October 18, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants