Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(optimizer): define crawlDeps after scanProcessing and optimizationResult are complete (fix #14284) #14285

Merged
merged 1 commit into from Sep 6, 2023
Merged

fix(optimizer): define crawlDeps after scanProcessing and optimizationResult are complete (fix #14284) #14285

merged 1 commit into from Sep 6, 2023

Conversation

anyesu
Copy link
Contributor

@anyesu anyesu commented Sep 4, 2023 •
edited

Description

Fixes

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Review PR in StackBlitz Codeflow Submitted with StackBlitz Codeflow.

@stackblitz
Copy link

stackblitz bot commented Sep 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added p4-important Violate documented behavior or significantly improves performance (priority) feat: deps optimizer Esbuild Dependencies Optimization labels Sep 6, 2023
sapphi-red
sapphi-red approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the detailed explanation and the fix!

@patak-dev patak-dev merged commit c5f6558 into vitejs:main Sep 6, 2023
12 checks passed
@anyesu anyesu deleted the anyesu/issue14284 branch September 7, 2023 02:55
Gaubee pushed a commit to Gaubee/vite that referenced this pull request Sep 13, 2023
@anyesu @Gaubee
fix(optimizer): define crawlDeps after scanProcessing and optimizatio…
32f8dd3 
…nResult are complete (fix vitejs#14284) (vitejs#14285)
@anyesu anyesu mentioned this pull request Sep 14, 2023
Open
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@anyesu @bluwy
fix(optimizer): define crawlDeps after scanProcessing and optimizatio…
4680cba 
…nResult are complete (fix #14284) (#14285)
@bluwy bluwy mentioned this pull request Oct 3, 2023
Merged
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@anyesu @bluwy
fix(optimizer): define crawlDeps after scanProcessing and optimizatio…
fcaf749 
…nResult are complete (fix #14284) (#14285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
feat: deps optimizer Esbuild Dependencies Optimization p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anyesu @patak-dev @sapphi-red