Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initWasm options should be optional #14152

Merged
merged 1 commit into from Aug 18, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Aug 18, 2023

Description

The importObject parameter is optional.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Aug 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

import initWasm from "${wasmHelperId}"
export default opts => initWasm(opts, ${JSON.stringify(url)})

const wasmHelper = async (opts = {}, url: string) => {

@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) feat: wasm labels Aug 18, 2023
@bluwy bluwy merged commit 387a6e8 into vitejs:main Aug 18, 2023
11 checks passed
@btea btea deleted the fix/wasm-importObject-optional branch August 18, 2023 23:46
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@bluwy bluwy mentioned this pull request Oct 3, 2023
bluwy pushed a commit that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: wasm p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants