fix(manifest): default description need to come from package #839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the default description in the web app manifest was not being populated from the
package.json
file, despite the type definition indicating this behavior. This change ensures that if no explicit description is provided in the plugin options, the description from the project'spackage.json
will be used as the default, aligning with the documented type definition intypes.ts
. This improves consistency and reduces the need for developers to duplicate the description in multiple places.Linked Issues
Additional Context
This change brings the runtime behavior in line with the existing type definition for
ManifestOptions
, ensuring that thedescription
field defaults to the value inpackage.json
, just likename
andshort_name
. This provides a more complete and convenient default configuration for the web app manifest and avoids potential confusion for developers expecting thedescription
to be automatically populated.