Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MapProvider prop types #1843

Merged
merged 3 commits into from
May 20, 2022
Merged

Conversation

shermify
Copy link
Contributor

As of React 18 (@types/react), children is no longer an implicit prop on the React.FunctionComponent type. This PR adds the type explicitly. More info here

DefinitelyTyped/DefinitelyTyped#46691
https://solverfox.dev/writing/no-implicit-children/

Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Pessimistress Pessimistress merged commit ecb27c8 into visgl:master May 20, 2022
Pessimistress pushed a commit that referenced this pull request May 20, 2022
@shermify shermify deleted the fix-map-provider-type branch May 24, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants