fix(mapbox) Remove type dependency on mapbox-gl #9279
Merged
+136
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
modules/mapbox/src/mapbox-layer.ts:61
- Using the non-null assertion operator '!' for 'this.map' assumes it is never null or undefined. Ensure 'this.map' is always defined at this point.
drawLayer(this.deck!, this.map!, this);
chrisgervang
approved these changes
Dec 6, 2024
chrisgervang
reviewed
Dec 6, 2024
chrisgervang
reviewed
Dec 6, 2024
| getFreeCameraOptions?(): FreeCameraOptions; | ||
|
|
||
| // This is not a public property | ||
| transform?: any; |
There was a problem hiding this comment.
Would this benefit from typing the properties we do use?
There was a problem hiding this comment.
The Transform classes in mapbox and maplibre are very different, I won't even bother...
Pessimistress
force-pushed
the
x/mapbox-types
branch
from
f0de611 to
a513cc1
Compare
Pessimistress
added a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9211
Dependency
@types/mapbox-glwas removed in v9.0 (unintentionally?) by #8204It wouldn't be compatible with maplibre-gl anyways...
Change List