Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CARTO): remove matching column prop from API reference #9002

Merged

Conversation

srtena
Copy link
Collaborator

@srtena srtena commented Jul 3, 2024

In #8971 we removed a matchingColumn prop from the CARTO module, specifically for the boundaryQuerySource and boundaryTableSource.

We need to reflect this in the API reference documentation

Changelog

  • Remove matchingColumn from the CARTO sources API reference
  • Add a small comment to guide developers when using Boundary sources

@srtena srtena added the doc label Jul 3, 2024
@srtena srtena requested a review from felixpalmer July 3, 2024 13:37
@srtena srtena self-assigned this Jul 3, 2024
@coveralls
Copy link

Coverage Status

coverage: 89.216%. remained the same
when pulling 2c8390b on srtena/CARTO-documentation-remove-matching-column-prop
into 220a07e on master.

@coveralls
Copy link

Coverage Status

coverage: 89.216%. remained the same
when pulling 5de6061 on srtena/CARTO-documentation-remove-matching-column-prop
into 220a07e on master.

@felixpalmer felixpalmer merged commit 31ff4bd into master Jul 3, 2024
4 checks passed
@donmccurdy donmccurdy deleted the srtena/CARTO-documentation-remove-matching-column-prop branch July 3, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants