fix(carto): Resolve conflicts between base URL and parameters #8925
+107
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
requestWithParameters
base URL conflicts with given parameters, override base URLDEFAULT_PARAMETERS
andDEFAULT_HEADERS
to local constants inrequest-with-parameters.ts
. When adding newDEFAULT_PARAMETERS
we need to be careful of the precedence (user params > default params > base url params) and that information is clearer in context.URLSearchParams#toString
handles whitespace and trailing slashes differently than the previous URL building logic.