Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): drawing layers with instance count 0 #8788

Merged
merged 3 commits into from
Apr 16, 2024
Merged

fix(core): drawing layers with instance count 0 #8788

merged 3 commits into from
Apr 16, 2024

Conversation

Pessimistress
Copy link
Collaborator

Closes #8776

Change List

  • Bump luma.gl to 9.0.10
  • Layer class only sets instance count of instanced model
  • Remove hack in plot example

@coveralls
Copy link

coveralls commented Apr 13, 2024 •
edited

Coverage Status

coverage: 90.002%. remained the same
when pulling 120ba38 on x/instance-fix
into 553ddff on master.

@Pessimistress Pessimistress merged commit 97476a5 into master Apr 16, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/instance-fix branch April 16, 2024 06:31
Pessimistress added a commit that referenced this pull request Apr 18, 2024
@Pessimistress
fix(core): drawing layers with instance count 0 (#8788)
2dd97aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Layer is not cleared when data is empty with version 9
3 participants
@Pessimistress @coveralls @ibgreen