Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to loaders@4.2 #8771

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Bump to loaders@4.2 #8771

merged 4 commits into from
Apr 10, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Apr 8, 2024

Closes #8621 #8746

Background

  • won't land until production 4.2 release is out.

Change List

@coveralls
Copy link

coveralls commented Apr 8, 2024

Coverage Status

coverage: 89.996%. remained the same
when pulling 79ac4b6 on loaders.gl@4.2
into 5cc3987 on master.

@Pessimistress Pessimistress changed the title test PR: Bump to loaders@4.2-beta Bump to loaders@4.2 Apr 9, 2024
@Pessimistress
Copy link
Collaborator

% yarn list "@loaders.gl/*"
yarn list v1.22.19
warning Filtering by arguments is deprecated. Please use the pattern option instead.
├─ @loaders.gl/3d-tiles@4.2.0
├─ @loaders.gl/compression@4.2.0
├─ @loaders.gl/core@4.2.0
├─ @loaders.gl/crypto@4.2.0
├─ @loaders.gl/csv@4.2.0
├─ @loaders.gl/draco@4.2.0
├─ @loaders.gl/gis@4.2.0
├─ @loaders.gl/gltf@4.2.0
├─ @loaders.gl/images@4.2.0
├─ @loaders.gl/loader-utils@4.2.0
├─ @loaders.gl/math@4.2.0
├─ @loaders.gl/mvt@4.2.0
├─ @loaders.gl/polyfills@4.2.0
├─ @loaders.gl/schema@4.2.0
├─ @loaders.gl/terrain@4.2.0
├─ @loaders.gl/textures@4.2.0
├─ @loaders.gl/tiles@4.2.0
├─ @loaders.gl/wms@4.2.0
├─ @loaders.gl/worker-utils@4.2.0
├─ @loaders.gl/xml@4.2.0
├─ @loaders.gl/zip@4.2.0
└─ @luma.gl/gltf@9.0.9
   ├─ @loaders.gl/images@4.1.4
   ├─ @loaders.gl/loader-utils@4.1.4
   ├─ @loaders.gl/schema@4.1.4
   ├─ @loaders.gl/textures@4.1.4
   └─ @loaders.gl/worker-utils@4.1.4
✨  Done in 0.61s.

@ibgreen
Copy link
Collaborator Author

ibgreen commented Apr 9, 2024

That's a surprise.. I would have assumed that the carets in loaders.gl package.json would have led to the same version being used across the board for all loaders.gl deps.

How would you like to handle it?

Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some v4.1 are still present in the dependency tree.

@Pessimistress
Copy link
Collaborator

@ibgreen

  • Bumping top-level dep versions does not affect nested deps
  • We need to update all deps in this repo for pre-built bundles to be generated correctly
  • We should bump the deps in luma, but for this PR you just need to fix yarn.lock

@Pessimistress Pessimistress marked this pull request as ready for review April 10, 2024 18:50
@ibgreen ibgreen merged commit 07db94b into master Apr 10, 2024
4 checks passed
@ibgreen ibgreen deleted the loaders.gl@4.2 branch April 10, 2024 18:59
Pessimistress pushed a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Info format is hardcoded to default value causing getFeatureInfoText to fail
3 participants