-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add necessary attributes in DataFilterExtension #8769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thoughts around the theme that less conditional code could be a goal worth considering.
uniform DATAFILTER_TYPE filter_max64High; | ||
#ifdef DATACATEGORY_TYPE | ||
#ifdef NON_INSTANCED_MODEL | ||
#define DATACATEGORY_ATTRIB filterCategoryValues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this, I ask myself if we really want to require an attribute that can be applied in both instanced and non-instanced usage should be renamed. This simple renaming adds a lot of clutter to this shader.
Can you add a few render tests (data filter, category filter & both)? |
Closes #8694
Change List
0
as value forfilterSize
&categorySize
categorySize
to0
to fix breaking change in v9