Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carto(v8): fetchLayerData to support columns prop for query sources #8412

Merged
merged 1 commit into from Jan 17, 2024
Merged

carto(v8): fetchLayerData to support columns prop for query sources #8412

merged 1 commit into from Jan 17, 2024

Conversation

zbigg
Copy link
Collaborator

@zbigg zbigg commented Jan 16, 2024 •
edited

Change List

  • carto(v8): fetchLayerData to support columns prop for query sources

@zbigg zbigg changed the base branch from master to 8.9-release January 16, 2024 13:26
felixpalmer
felixpalmer approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@felixpalmer felixpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine, just needs test against API as discussed

@zbigg zbigg merged commit 69f2c86 into 8.9-release Jan 17, 2024
@felixpalmer felixpalmer deleted the zbigg/carto-fetch-map-columns branch January 18, 2024 08:52
@zbigg zbigg mentioned this pull request Jan 19, 2024
Merged
@DanyRay420 DanyRay420 mentioned this pull request Feb 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

@padawannn padawannn Awaiting requested review from padawannn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zbigg @felixpalmer