Type lost on str_starts_with() invoke

[SCIF]

https://psalm.dev/r/b5e0e01fa3

Probably introduced some side-effect in #9534 but not sure tbh. I checked PR's content and it does look correct to me, so don't have idea how to fix that.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/b5e0e01fa3

<?php

/**
 * @return string|null
 */
function getStr() {
    return rand() > 5 ? '' : null;
}

$b = getStr();
$c = getStr();

if (!is_string($b) || !str_starts_with($b, 'prefix') || strlen($b) > 4) {
    throw new \Exception('Assert');
}
/** @psalm-trace $b */;
 
if (!is_string($c) || strlen($c) > 4) {
    throw new \Exception('Assert');
}

Psalm output (using commit fd4f7b7):

ERROR: PossiblyNullArgument - 13:64 - Argument 1 of strlen cannot be null, possibly null value provided

INFO: Trace - 16:23 - $b: null|string

[SCIF]

@fluffycondor , could you please step in, if possible?

[fluffycondor]

Looks like #9575 causes it :(
Currently negation of =assertions does nothing. Sorry to hear it even resets the type.
It works as expected without early returning
https://psalm.dev/r/8745d43ac6
Or you can split the condition
https://psalm.dev/r/f8959696d0

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/8745d43ac6

<?php

/**
 * @return string|null
 */
function getStr() {
    return rand() > 5 ? '' : null;
}

$b = getStr();

if (is_string($b) && str_starts_with($b, 'prefix') && strlen($b) > 4) {
	/** @psalm-trace $b */;
} else {
    throw new \Exception('Assert');
}

Psalm output (using commit 71bb951):

INFO: Trace - 13:24 - $b: non-empty-string

https://psalm.dev/r/f8959696d0

<?php

/**
 * @return string|null
 */
function getStr() {
    return rand() > 5 ? '' : null;
}

$b = getStr();

if (!is_string($b)) {
    throw new \Exception('Assert');
}
if (!str_starts_with($b, 'prefix') || strlen($b) > 4) {
    throw new \Exception('Assert');
}
/** @psalm-trace $b */;

Psalm output (using commit 71bb951):

INFO: Trace - 18:23 - $b: string