Can not use class constants type as part of new list{} (n-tuple) types

[gmazzap]

In Psalm v5, we can now define n-tuple types via list{T1, T2}.

For a while now, we can also use ClassName::SOME_PREFIX_* to declare a type pointing to a set of class constants having a given prefix.

However, we can't use the two things together. See:

https://psalm.dev/r/f185d94aae

I'm guessing Psalm finds a :: inside an array-type definition and assumes it is an array key, not considering it could be an array value.

Edit: please note, in array-shapes definition it works: https://psalm.dev/r/9df7ce7dca so looks like it is really a matter of Psalm assuming :: is used in the key.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/f185d94aae

<?php

class Test
{
    public const C_1 = 'one';
    public const C_2 = 'two';
    
    /**
     * @return list{Test::C_*, bool}
     */
    public function pickOne(): array
    {
        $value = random_int(0, 5) > 2 ? self::C_1 : self::C_2;
        
        return [$value, true];
    }
}

Psalm output (using commit 1cd10c3):

ERROR: InvalidDocblock - 11:5 - :: in array key is only allowed for ::class in docblock for Test::pickOne

[weirdan]

Implemented in #10678