Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc doc changes #37

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Misc doc changes #37

merged 1 commit into from
Apr 10, 2022

Conversation

kianmeng
Copy link
Contributor

Besides other documentation changes, this commit includes all relevant
documents to the generated HTML doc for HexDocs.pm and leverages on
latest features of ExDoc.

Besides other documentation changes, this commit includes all relevant
documents to the generated HTML doc for HexDocs.pm and leverages on
latest features of ExDoc.
@kianmeng
Copy link
Contributor Author

kianmeng commented Apr 4, 2022

@vic Any updates on this?

@vic
Copy link
Owner

vic commented Apr 5, 2022

Hey @kianmeng, would you be interested in being a maintainer to this repo? I've not used elixir since ~2017, I'll be adding a code-owners file on this repo, so other maintainers (I believe it was three people) can take a look and test/merge PRs sooner than me. If you are willing, you are more than welcome to become a maintainer, just send me your hex.pm username.

@vic vic requested review from lasseebert and take-five April 5, 2022 07:38
Copy link
Contributor

@lasseebert lasseebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed very nice improvements to the docs 🎉
I think @vic should review the changes made to the license file.

I wil soon not be using Params professionally anymore (because I change job), so I will probably not be around as a maintainer for this project.

@kianmeng
Copy link
Contributor Author

@vic @lasseebert

Perhaps put notice in Git repo, Hex info page, adoptoposs.org or elixirforum.com looking for maintainers?

If there are no responses within a month or so, just archived the Git repo (to prevent further PRs), and put "not maintain any more" notice to Git repo and Hex info page.

@vic
Copy link
Owner

vic commented Apr 10, 2022

are you willing you contribute your time on this ? again, if you do, I'm willing to add you as contributor so you can help fix exactly what you are mentioning about keeping this repo more up to date.

this project has two other maintainers (with merge and hex.pm access for creating releases) but things always depend on these people's availability, something we can never ask for.

Being open source, projects belong to their users, code that once was useful to me and just extracted it into a repo in hope it could be of help to anyone else. you can do whatever you like of it as long as you adhere to the license.

If you truly care about it, as it seems, the invitation is open to become a maintainer and help those still using this repo, and finally merge this yourself.

@vic
Copy link
Owner

vic commented Apr 10, 2022

changes lgtm, except for adding a broken link to Twitter.

@kianmeng
Copy link
Contributor Author

@vic Thanks for asking again. Sorry, I'm not looking into adopting any FLOSS projects. 😅

@kianmeng
Copy link
Contributor Author

changes lgtm, except for adding a broken link to Twitter.

@vic FYI. The Twitter link, https://twitter.com/vborja, added README.md in master branch, point to a suspended Twitter account.

Screenshot-20220410222747-1640x1204

@vic vic merged commit 9b79bd7 into vic:master Apr 10, 2022
@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants