Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster check_non_configurable_edges #2839

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Faster check_non_configurable_edges #2839

merged 7 commits into from
Jan 28, 2025
+101 −47

Conversation

soheilshahrouz
Copy link
Contributor

Addresses this issue.

@soheilshahrouz
use std::vector instead of std::set to make sure that node_sets and e…
Loading
Loading status checks…
ffcead7 
…dge_sets are stored in the same order
@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Dec 4, 2024
@soheilshahrouz
Copy link
Contributor Author

@vaughnbetz
I recall you wrote some comments on this PR. Could you please release them?

vaughnbetz
vaughnbetz reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; a few suggested commenting changes and a loop-style change.

@soheilshahrouz soheilshahrouz changed the title [WIP] Faster check_non_configurable_edges Faster check_non_configurable_edges Jan 28, 2025
AlexandreSinger
AlexandreSinger approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandreSinger AlexandreSinger merged commit 7829f79 into master Jan 28, 2025
36 checks passed
@AlexandreSinger AlexandreSinger deleted the temp_faster_check_non_configurable_edges branch January 28, 2025 19:23
@AlexandreSinger AlexandreSinger mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz

@AlexandreSinger AlexandreSinger

Assignees
No one assigned
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@soheilshahrouz @vaughnbetz @AlexandreSinger