fix(tui): generate stop event on ctrl c #9296
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we had used a
None
return from the input handler as a signal that the TUI should shut down. We no longer do this so we need to explicitly returnEvent::InternalStop
to signal that we should shut down the TUI.Testing Instructions
Start up a dev task with 2.2.1 and observe that on Ctrl-C the terminal is left in raw mode:
![Screenshot 2024-10-20 at 3 31 40 PM](https://private-user-images.githubusercontent.com/4131117/378219998-9b8abf85-20b6-4991-aa64-09a1edcc617b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0ODg1ODgsIm5iZiI6MTczOTQ4ODI4OCwicGF0aCI6Ii80MTMxMTE3LzM3ODIxOTk5OC05YjhhYmY4NS0yMGI2LTQ5OTEtYWE2NC0wOWExZWRjYzYxN2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMjMxMTI4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzNlODJjMDM1MDZlNmUzMTAwN2E1NGM0NGRiNDgyNTM0ZGZjNzRiYWIzNzEwMGMwMTllNmJlZTQ0MTVkNzE3MiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.zYO_Hnbh6cyCgwGal4MwqPMoew-J8VgG5c0jMsbXlT4)
With the build from the PR you should note that the on Ctrl-C the terminal is returned to a cooked mode:
![Screenshot 2024-10-20 at 3 32 14 PM](https://private-user-images.githubusercontent.com/4131117/378220005-521381d6-6a28-4dbb-b56b-0d1cae7fbd27.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0ODg1ODgsIm5iZiI6MTczOTQ4ODI4OCwicGF0aCI6Ii80MTMxMTE3LzM3ODIyMDAwNS01MjEzODFkNi02YTI4LTRkYmItYjU2Yi0wZDFjYWU3ZmJkMjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMjMxMTI4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTllM2ZiMDk5OGM2MmQ1NzYzMTM2MTIxMTBkNzRiMWQ1NGU2ZjQyNTdkZDY5ZGM1NzhlZmY5NGFjYzMwZmM1YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.1YrGlpg1MhkZfm_IPBJDLdkOIyDjVFfibOWGPZ1HGKY)